Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDH-PlayTime #735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ynhhoJ
Copy link

@ynhhoJ ynhhoJ commented Dec 28, 2024

SDH-PlayTime

This is a fork of original plugin SDH-PlayTime which is archived right now.

In this update was:

  • Improved code formatting (back-end & front-end)
  • Fixed a case when EA Games play time session was not detected right.
  • Implemented support of multiple sessions
    image

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@ynhhoJ ynhhoJ requested a review from a team as a code owner December 28, 2024 17:27
@1basti1
Copy link

1basti1 commented Dec 28, 2024

I already tested a provided .zip file from @ynhhoJ and so far everything seems to work great.

But unfortunately I can't test EA games, because I don't have any.

I was using the old Playtime plugin since the beginning, even fixed .zip files from the original author and another contributor, which where never pushed to the testing store unfortunately.

This "update" works with the old files. So everyone who was using the old Playtime plugin or fixed versions can just upgrade and everything will be working.

Ok, found some bugs after further testing.
Starting here: https://discord.com/channels/960281551428522045/1087800823846813716/1323643482887295058

Nothing to serious.

Edit: January 1st, these problems got fixed now. This plugin should go into the testing store.

@ynhhoJ ynhhoJ changed the title Add SDH-PlayTime Draft: Add SDH-PlayTime Dec 31, 2024
@ynhhoJ ynhhoJ marked this pull request as draft December 31, 2024 14:46
@ynhhoJ ynhhoJ changed the title Draft: Add SDH-PlayTime Add SDH-PlayTime Dec 31, 2024
@ynhhoJ
Copy link
Author

ynhhoJ commented Dec 31, 2024

Was founded a bug which should be fixed

@ynhhoJ ynhhoJ marked this pull request as ready for review January 1, 2025 14:08
@ynhhoJ
Copy link
Author

ynhhoJ commented Jan 1, 2025

Synced with latest changes from main branch & pushed Fixed a SessionPlayTime calculation bug caused by "Suspended" & "ResumeFromSuspended" events. MR

Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy smokes, that was a lot of code! Looks fine to me, good for testing. Thanks for the update :)

@1basti1
Copy link

1basti1 commented Jan 2, 2025

For good measure I uninstalled the provided .zip and installed the testing store version.

Everything works as expected for me. 👍🏻

@eduardlleshi
Copy link

I upgraded to the testing store version and everything has been working as expected. This has fixed two issues I had in the past with 1.0.2 (counting sleep time + multiple sessions).

I tested with Steam, non-Steam (Heroic), and emulated games and they are working as expected in the version. The upgrade is compatible with the previous versions and all the data was already there. I had already made a backup of storage.db but that wasn't necessary. @ynhhoJ thanks for all the effort in these updates!

@DarkSide1305
Copy link

DarkSide1305 commented Jan 2, 2025

I updated from an ancient version and I don't think ive installed an version that didnt come from the store in months other then very old ma3a releases when Playtime literally full on broke. And even upgrading from that old version, everything works without an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants